Conf: ensure that the default path is NUL-terminated. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the default state path generation where paths were not being NUL-terminated when using absolute paths with NGX_ACME_STATE_PREFIX. This caused filesystem corruption with garbled directory names containing unprintable characters.
Key changes:
- Increased memory reservation to account for NUL terminator
- Added explicit NUL byte to path buffer
- Adjusted returned length to exclude NUL terminator from string length
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ensh63
approved these changes
Oct 6, 2025
xeioex
reviewed
Oct 7, 2025
`ngx_conf_merge_path_value` takes care of that when it reallocates a resolved relative path, but the reallocation is skipped if we pass an absolute path with `NGX_ACME_STATE_PREFIX`.
bavshin-f5
force-pushed
the
nul-terminated-paths
branch
from
18c4d07 to
2b84d85
Compare
xeioex
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx_merge_path_valuetakes care of that when it reallocates a resolved relative path, but the reallocation is skipped if we pass an absolute path withNGX_ACME_STATE_PREFIX.As a result, we get a lovely
Note for future: we need to enforce such requirements in a type system, e.g. by requiring
CStrfor path operations in ngx-rust.